Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSAT Widget aria-invalid without form submission #865

Open
danielclubb opened this issue Jan 11, 2023 · 0 comments
Open

CSAT Widget aria-invalid without form submission #865

danielclubb opened this issue Jan 11, 2023 · 0 comments
Labels
bug Something isn't working global global toolkit issue

Comments

@danielclubb
Copy link
Contributor

Hi team,

We think we have found an issue with the CSAT widget implementation.

If we provide an error property in the json config data required to use the widget, we get an accessibility error because the CSAT form has an aria-invalid="true" property by default, without the form having been submitted.

If we remove the error property from the json config data, then the accessibility error goes away, however, the error state is then broken as it does not have an error message to display.

We think this is happening because the template logic of the CSAT component looks for error in the context in order to add/remove the aria-invalid="true" attribute, and when this is provided in the json data, the attribute is added by default.

If the property were to be renamed to errorMessage or something similar that isn't just error we think this would fix it.

Thanks!

CC: Andreas Koscinski <[email protected]>, Daniel Clubb <[email protected]>, Morgan Cugerone <[email protected]>

@sturobson sturobson added bug Something isn't working global global toolkit issue labels Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working global global toolkit issue
Projects
None yet
Development

No branches or pull requests

2 participants