Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update quickstart example code to include provider for 1271 support #203

Open
mihoward21 opened this issue May 20, 2024 · 1 comment
Open

Comments

@mihoward21
Copy link

Both the backend quickstart and the complete app quickstart are missing the provider in the call to verify, meaning no 1271 support. I think it'd be good to include these in any sample code you provide, would help grow support for 1271 in all the apps using siwe. I've come across many apps that don't support it (I assume they just did not think about it, instead of explicitly deciding to not support it).

Not sure if there are other things to do to promote 1271 support, but I think it'd be great for you all to highlight it. Maybe in a future version of the package it could be required by default and users would have to explicitly opt out instead of having to remember to pass in a provider.

@sbihel
Copy link
Member

sbihel commented May 23, 2024

This is a good point. Are there providers that we can reliably point users to, with no set-up required?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants