Skip to content
This repository has been archived by the owner on Mar 21, 2023. It is now read-only.

Should check that required ports are open #39

Open
artisgarbage opened this issue Sep 18, 2017 · 4 comments
Open

Should check that required ports are open #39

artisgarbage opened this issue Sep 18, 2017 · 4 comments
Assignees

Comments

@artisgarbage
Copy link
Contributor

having another process running on :443 will prevent sprucebot platform start command from completing, CLI should check that this port and any other required ports are open.

@elkwood
Copy link
Contributor

elkwood commented Sep 19, 2017

@artisgarbage This requires the start command to run with root privileges. Seems better to me to just rely on the tooling to report that something is listening on port 443

@artisgarbage
Copy link
Contributor Author

can't we just sniff it with something like portfinder to prevent going all the way down the rabbit hole before hitting a problem?

@elkwood
Copy link
Contributor

elkwood commented Sep 19, 2017

That package still delegates to a net.createServer().listen(port) call. That will throw EACCESS when that command tries to listen on port < 1024. Since we're trying to listen on 80, we don't really know if something is listening already or not.

@artisgarbage
Copy link
Contributor Author

grrr

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants