Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CC-34718 Removed ability to create new QS accounts. #14

Conversation

ilyakubanov
Copy link
Collaborator

@ilyakubanov ilyakubanov commented Nov 5, 2024

Release Table

Module Release Type Constraint Updates
AmazonQuicksight major

Module AmazonQuicksight

Change log

Breaking Changes

  • Adjusted AmazonQuicksightFacade::enableAnalytics() so it does not create or upgrade Quicksight users anymore.
  • Removed AmazonQuicksightFacade::createQuicksightUsersByUserCollectionResponse().
  • Removed AmazonQuicksightFacade::deleteNotMatchedQuicksightUsers().
  • Removed CreateQuicksightUserPostUpdatePlugin.
  • Removed QuicksightUserPostCreatePlugin.
  • Removed QuicksightUserRoleUserFormExpanderPlugin.
  • Removed AmazonQuicksightConfig::isQuicksightUserRoleUpdateEnabled().
  • Removed QuicksightUserSyncDeleteConsole.
  • Removed QuicksightUserRegisterRequest transfer.
  • Removed QuicksightUserRegisterResponse transfer.
  • Removed QuicksightUpdateUserRequest transfer.
  • Removed QuicksightUpdateUserResponse transfer.
  • Removed user-form-quicksight-user-role-field.twig template.

Improvements

  • Adjusted AmazonQuicksightFacade::expandAnalyticsCollectionWithQuicksightAnalytics() to expand analytics collection with synchronize Quicksight users action.
  • Introduced UserController::synchronizeQuicksightUsersAction() to synchronize Quicksight users.
  • Introduced synchronize-quicksight-users-action.twig template to provide an ability to synchronize users.
  • Adjusted quicksight-analytics.twig template to provide better UI.

Adjustments

  • Removed MessengerFacade::addErrorMessage() from dependencies.
  • Adjusted height of the iframe to consume all free space on the page.

@ilyakubanov ilyakubanov changed the title Feature/cc 34718/dev remove ability to create new qs accounts CC-34718 Removed ability to create new QS accounts. Nov 7, 2024
@pyvovarov-s
Copy link
Collaborator

please do not forget to exapnd change logs with FE changes

…counts' of github.com:spryker-eco/amazon-quicksight into feature/cc-34718/dev-remove-ability-to-create-new-qs-accounts
@pyvovarov-s
Copy link
Collaborator

pyvovarov-s commented Nov 21, 2024

I looks like this is not being used anywhere \SprykerEco\Zed\AmazonQuicksight\Persistence\AmazonQuicksightEntityManager::deleteQuicksightUsers please check full codebase for such cases

@spryker-release-bot spryker-release-bot merged commit 4cb2e75 into master Nov 28, 2024
2 checks passed
@spryker-release-bot spryker-release-bot deleted the feature/cc-34718/dev-remove-ability-to-create-new-qs-accounts branch November 28, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants