-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CC-34718 Removed ability to create new QS accounts. #14
Merged
spryker-release-bot
merged 20 commits into
master
from
feature/cc-34718/dev-remove-ability-to-create-new-qs-accounts
Nov 28, 2024
Merged
CC-34718 Removed ability to create new QS accounts. #14
spryker-release-bot
merged 20 commits into
master
from
feature/cc-34718/dev-remove-ability-to-create-new-qs-accounts
Nov 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tolerants
requested changes
Nov 7, 2024
...ykerEco/Zed/AmazonQuicksight/Presentation/_partials/synchronize-quicksight-users-action.twig
Outdated
Show resolved
Hide resolved
tolerants
approved these changes
Nov 7, 2024
tolerants
requested changes
Nov 7, 2024
src/SprykerEco/Zed/AmazonQuicksight/Presentation/_partials/quicksight-analytics.twig
Outdated
Show resolved
Hide resolved
…cksight-analytics.twig
tolerants
approved these changes
Nov 7, 2024
pyvovarov-s
reviewed
Nov 8, 2024
src/SprykerEco/Zed/AmazonQuicksight/Business/Expander/AnalyticsExpander.php
Outdated
Show resolved
Hide resolved
src/SprykerEco/Zed/AmazonQuicksight/Business/Expander/AnalyticsExpander.php
Outdated
Show resolved
Hide resolved
src/SprykerEco/Zed/AmazonQuicksight/Business/Expander/AnalyticsExpander.php
Show resolved
Hide resolved
src/SprykerEco/Zed/AmazonQuicksight/Business/Deleter/QuicksightUserDeleter.php
Outdated
Show resolved
Hide resolved
src/SprykerEco/Zed/AmazonQuicksight/Business/Validator/QuicksightAnalyticsRequestValidator.php
Outdated
Show resolved
Hide resolved
src/SprykerEco/Zed/AmazonQuicksight/Communication/Controller/UserController.php
Outdated
Show resolved
Hide resolved
please do not forget to exapnd change logs with FE changes |
…counts' of github.com:spryker-eco/amazon-quicksight into feature/cc-34718/dev-remove-ability-to-create-new-qs-accounts
I looks like this is not being used anywhere \SprykerEco\Zed\AmazonQuicksight\Persistence\AmazonQuicksightEntityManager::deleteQuicksightUsers please check full codebase for such cases |
pyvovarov-s
reviewed
Nov 21, 2024
src/SprykerEco/Zed/AmazonQuicksight/Communication/Controller/UserController.php
Outdated
Show resolved
Hide resolved
pyvovarov-s
approved these changes
Nov 21, 2024
tolerants
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developer(s): @ilyakubanov
Ticket: https://spryker.atlassian.net/browse/CC-34718
Release Group: https://release.spryker.com/release-groups/view/5613
merge: merge
Release Table
Module AmazonQuicksight
Change log
Breaking Changes
AmazonQuicksightFacade::enableAnalytics()
so it does not create or upgrade Quicksight users anymore.AmazonQuicksightFacade::createQuicksightUsersByUserCollectionResponse()
.AmazonQuicksightFacade::deleteNotMatchedQuicksightUsers()
.CreateQuicksightUserPostUpdatePlugin
.QuicksightUserPostCreatePlugin
.QuicksightUserRoleUserFormExpanderPlugin
.AmazonQuicksightConfig::isQuicksightUserRoleUpdateEnabled()
.QuicksightUserSyncDeleteConsole
.QuicksightUserRegisterRequest
transfer.QuicksightUserRegisterResponse
transfer.QuicksightUpdateUserRequest
transfer.QuicksightUpdateUserResponse
transfer.user-form-quicksight-user-role-field.twig
template.Improvements
AmazonQuicksightFacade::expandAnalyticsCollectionWithQuicksightAnalytics()
to expand analytics collection with synchronize Quicksight users action.UserController::synchronizeQuicksightUsersAction()
to synchronize Quicksight users.synchronize-quicksight-users-action.twig
template to provide an ability to synchronize users.quicksight-analytics.twig
template to provide better UI.Adjustments
MessengerFacade::addErrorMessage()
from dependencies.