Externalize data to make the website translatable and add Spanish translation #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e.js`, to be moved into an external JSON file
✅ Deploy Preview for spyder-website-preview ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
…. Updated some packages
…slation support to the Blog, Download and About pages
conradolandia
force-pushed
the
front-page-object
branch
from
66b8a8d to
312ea20
Compare
…s in the front page
…arnings on Chrome
…s (non-translatable strings and settings)
…ove formatting on some files
This was referenced Feb 5, 2025
ccordoba12
reviewed
Feb 10, 2025
There was a problem hiding this comment.
This is a fantastic improvement @conradolandia!! Thanks a lot for your work on it!
I left several suggestions for the Spanish translation, the rest looks good to me.
ccordoba12
changed the title
Co-authored-by: Carlos Cordoba <[email protected]>
conradolandia
commented
Feb 10, 2025
ccordoba12
approved these changes
Feb 10, 2025
conradolandia
added a commit
to conradolandia/spyder-website
that referenced
this pull request
Feb 11, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to find and externalize all static data on the website so it can be imported from YAML files.
The website now loads its data from 4 sources, depending on the needed data:
$lib/config/content.yaml. The file$lib/config/index.jsloads data from the YAML source and exports variables accordingly. This preserves compatibility with the previous configuration.routes/content.yamlwill provide content for the front page,routes/about/content.yamlwill provide content for the/aboutroute, and so on. Only the/blogroute does not require an external content file.Fixes #21
Fixes #8