From 573f9a1a5147995c12229f5e475354a0f300436a Mon Sep 17 00:00:00 2001 From: Sayan Naskar Date: Fri, 16 Aug 2024 20:46:34 +0530 Subject: [PATCH 1/2] Remove unused var inRangeNumbers --- sqids.lua | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/sqids.lua b/sqids.lua index 80452f5..258c3b5 100644 --- a/sqids.lua +++ b/sqids.lua @@ -255,16 +255,6 @@ function Sqids:encode(numbers) return '' end - -- don't allow out-of-range numbers [might be lang-specific] - local inRangeNumbers = {} - for _, n in ipairs(numbers) do - if n >= 0 and n <= maxValue() then - table.insert(inRangeNumbers, n) - else - error("Encoding supports numbers between 0 and " .. maxValue()) - end - end - return encodeNumbers(self, numbers) end From eca0e830a2a6fd161eed1b0bdabcc4ee89a8e1c8 Mon Sep 17 00:00:00 2001 From: Sayan Naskar Date: Mon, 19 Aug 2024 16:11:36 +0530 Subject: [PATCH 2/2] fix --- sqids.lua | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/sqids.lua b/sqids.lua index 258c3b5..32c17bf 100644 --- a/sqids.lua +++ b/sqids.lua @@ -255,6 +255,13 @@ function Sqids:encode(numbers) return '' end + -- don't allow out-of-range numbers + for _, n in ipairs(numbers) do + if n < 0 or n > maxValue() then + error("Encoding supports numbers between 0 and " .. maxValue()) + end + end + return encodeNumbers(self, numbers) end