Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how IDbConnection is managed #4

Open
benmccallum opened this issue Jan 16, 2020 · 1 comment
Open

Document how IDbConnection is managed #4

benmccallum opened this issue Jan 16, 2020 · 1 comment

Comments

@benmccallum
Copy link

Further to this issue on core proj, documentation should explicitly state how the IDbConnection is managed.

Specifically, this comment, highlights three places that should be updated.

  1. The readme under Setup Connection just new's up a SqlConnection without highlighting it'd need to be disposed.
  2. The docs online under Query Factory should a similar story
  3. The asp.net core example with DI is similar, but even worse, in that it looks like that's all you'd have to do, and the DI container, when it deconstructs the QueryFactory will just dispose the connection for you, but as we know, that's not the case.

However, if the core library changes to have IQueryFactory implement IDisposable, then the wording required would change.

@ghost
Copy link

ghost commented Jun 8, 2020

Could we get an estimate on when documentation will get updated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant