Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace use of synchronized in OkHttpCall with ReentrantLock #4297

Open
bendb-instacart opened this issue Feb 4, 2025 · 0 comments
Open

Replace use of synchronized in OkHttpCall with ReentrantLock #4297

bendb-instacart opened this issue Feb 4, 2025 · 0 comments

Comments

@bendb-instacart
Copy link

We use Retrofit in our backend, and I notice that retrofit2.OkHttpCall relies extensively on synchronized(this), which can pin host threads (when using virtual threads). Would you be open to a PR replacing use of synchronized here with use of ReentrantLock?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bendb-instacart