Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extracting audio from video file example #6

Merged
merged 1 commit into from
Oct 4, 2018
Merged

extracting audio from video file example #6

merged 1 commit into from
Oct 4, 2018

Conversation

kishorerabha
Copy link
Contributor

@kishorerabha kishorerabha commented Oct 4, 2018 •
edited by srbcheema1
Loading

Partially fix the issue #1

@kishorerabha
Copy link
Contributor Author

Is this okay? Should I add more gifs?

@srbcheema1
Copy link
Owner

srbcheema1 commented Oct 4, 2018 •
edited
Loading

awesome work @kishorerabha :)
Really outstanding. This Gif is well explanatory with proper commentary.
I would recommend you to please have a look at srbcheema1/CoolKit#1
This is a similar issue but a better tool than this one. I would love to see your contribution on that tool

A free tip. never leave description of PR blank. please mention what this PR is doing and also mention the issue number if it is fixing any issue fully or partially.

@srbcheema1 srbcheema1 merged commit d624a59 into srbcheema1:master Oct 4, 2018
@srbcheema1 srbcheema1 mentioned this pull request Oct 4, 2018
Open
@kishorerabha
Copy link
Contributor Author

okay thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kishorerabha @srbcheema1