You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Have an example branch (policy will rename to this issue number) with some suggested changes, may not have worked out the kinks yet.
But....
A PolicyDispatcher always additionally needs to inherit an EventListener. The srcSAXEventDispatcher requires it. I say we make a PolicyDispatcher inherit from EventListener so we are not requiring clients to do both. Its confusing.
Took a while to figure out how things work again, possibly because of this.
Slightly related, I made the constructor accept multiple PolicyListeners (in addition to multiple EventListeners). So, consistent.
The text was updated successfully, but these errors were encountered:
Not sure if it is a good idea as well, but we could also do the following to simplify things.
Eliminate EventListener make it a part of PolicyDispatcher.
Rename PolicyDispatcher to Policy as that is what we refer to them as.
Maybe rename EventDispatcher to Dispatcher, move it to dispatcher, or remove it. Or some combination. The remove it would be a move from the Polymorphic open/closed principle to the Meyer's open/closed principle. Although, I tend to like the Polymorphic one.
This may people do not get confused with what a policy listener and dispatcher is and what an event listener and dispatcher is and when to use them. Someone would only need to know about policy listener/dispatcher and event would be pretty much hidden. Problem is they are forced to implement DataInner.
Have an example branch (policy will rename to this issue number) with some suggested changes, may not have worked out the kinks yet.
But....
A PolicyDispatcher always additionally needs to inherit an EventListener. The srcSAXEventDispatcher requires it. I say we make a PolicyDispatcher inherit from EventListener so we are not requiring clients to do both. Its confusing.
Took a while to figure out how things work again, possibly because of this.
Slightly related, I made the constructor accept multiple PolicyListeners (in addition to multiple EventListeners). So, consistent.
The text was updated successfully, but these errors were encountered: