Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update error returned from deserialization of error message in paging. #436

Open
sreeise opened this issue May 14, 2023 · 0 comments
Open
Labels
good first issue Good for newcomers

Comments

@sreeise
Copy link
Owner

sreeise commented May 14, 2023

This line makes it so that any error that is not an ErrorMessage will get overwritten with the default ErrorMessage. Instead this should just return the original error if we cannot deserialize it into an ErrorMessage.

.map_err(|_| serde_json::from_value(json.clone()).unwrap_or(ErrorMessage::default()));

.map_err(|_| serde_json::from_value(json.clone()).unwrap_or(ErrorMessage::default()));

@sreeise sreeise added the good first issue Good for newcomers label May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant