Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify all agents for all sims working #26

Open
ShvetankPrakash opened this issue Oct 5, 2023 · 4 comments
Open

Verify all agents for all sims working #26

ShvetankPrakash opened this issue Oct 5, 2023 · 4 comments
Assignees

Comments

@ShvetankPrakash
Copy link
Collaborator

It appears many agents are not working out of the box. We should verify all of them and add the necessary documentation,

@ShvetankPrakash
Copy link
Collaborator Author

For example:

$ python train_randomwalker_DRAMSys.py 
Traceback (most recent call last):
  File "/home/oss-arch-gym/sims/DRAM/train_randomwalker_DRAMSys.py", line 11, in <module>
    from arch_gym.envs import dramsys_wrapper
  File "/home/oss-arch-gym/arch_gym/envs/dramsys_wrapper.py", line 19, in <module>
    from acme import specs
ImportError: cannot import name 'specs' from 'acme' (unknown location)

We need to add something like os.sys.path.insert(0, os.path.abspath('../../acme')) like in train_ppo.py under sims/DRAM

@ShvetankPrakash
Copy link
Collaborator Author

Noting here that @manan-garg1504 is working with @aadyapipersenia04 to add acme to install script for this issue

@manan-garg1504
Copy link
Collaborator

@AditiR-42 I was trying to run astra-sim after a clean install, but now the submodule cloning fails:

$ git submodule update --init --recursive  sims/AstraSim/astrasim-archgym
fatal: remote error: upload-pack: not our ref 53574d2f1d20e26d5143eb0ff0c98b6af338da61
fatal: Fetched in submodule path 'sims/AstraSim/astrasim-archgym', but it did not contain 53574d2f1d20e26d5143eb0ff0c98b6af338da61. Direct fetching of that commit failed.

Does the documentation need to be updated?

@ShvetankPrakash
Copy link
Collaborator Author

Thanks for working on this @manan-garg1504 ! @AditiR-42 @jared-ni can you help him resolve the issue. We want AstraSim working out of the box for the conference this week :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants