vr-bgp integration

[bdreisbach]

i am looking into vr-bgp integration, this seems to work but looking for feedback on the method(ive not written go before). i have a modified version of vr-bgp that doesnt need vr-xcon(i can provide a patch for your vrnetlab fork as well). not sure if there is a better way than using env variables for this. thoughts?

+++ b/clab/vr-bgp.go
@@ -0,0 +1,79 @@
+package clab
+
+import "fmt"
+
+func initVrBgpNode(c *CLab, nodeCfg NodeConfig, node *Node, user string, envs map[string]string) error {
+       var err error
+
+       node.Image = c.imageInitialization(&nodeCfg, node.Kind)
+       node.Group = c.groupInitialization(&nodeCfg, node.Kind)
+       node.Position = c.positionInitialization(&nodeCfg, node.Kind)
+       node.User = user
+
+       // env vars are used to set launch.py arguments in vrnetlab container
+       defEnv := map[string]string{
+               "CONNECTION_MODE":    vrDefConnMode,
+               "DOCKER_NET_V4_ADDR": c.Config.Mgmt.IPv4Subnet,
+               "DOCKER_NET_V6_ADDR": c.Config.Mgmt.IPv6Subnet,
+       }
+       node.Env = mergeStringMaps(defEnv, envs)
+
+       if node.Env["CONNECTION_MODE"] == "macvtap" {
+               // mount dev dir to enable macvtap
+               node.Binds = append(node.Binds, "/dev:/dev")
+       }
+
+       cmd := ""
+       if len(node.Env["IPV4_LOCAL_ADDRESS"]) > 0 {
+               cmd += fmt.Sprintf(" --ipv4-local-address %s", node.Env["IPV4_LOCAL_ADDRESS"])
+       }
+       if len(node.Env["IPV4_NEIGHBOR"]) > 0 {
+               cmd += fmt.Sprintf(" --ipv4-neighbor %s", node.Env["IPV4_NEIGHBOR"])
+       }
+       if len(node.Env["IPV4_PREFIX"]) > 0 {
+               cmd += fmt.Sprintf(" --ipv4-prefix %s", node.Env["IPV4_PREFIX"])
+       }
+       if len(node.Env["IPV4_NEXTHOP"]) > 0 {
+               cmd += fmt.Sprintf(" --ipv4-nexthop %s", node.Env["IPV4_NEXTHOP"])
+       }
+        if len(node.Env["IPV6_LOCAL_ADDRESS"]) > 0 {
+                cmd += fmt.Sprintf(" --ipv6-local-address %s", node.Env["IPV6_LOCAL_ADDRESS"])
+        }
+        if len(node.Env["IPV6_NEIGHBOR"]) > 0 {
+                cmd += fmt.Sprintf(" --ipv6-neighbor %s", node.Env["IPV6_NEIGHBOR"])
+        }
+        if len(node.Env["IPV6_PREFIX"]) > 0 {
+                cmd += fmt.Sprintf(" --ipv6-prefix %s", node.Env["IPV6_PREFIX"])
+        }
+        if len(node.Env["IPV6_NEXTHOP"]) > 0 {
+                cmd += fmt.Sprintf(" --ipv6-nexthop %s", node.Env["IPV6_NEXTHOP"])
+        }
+        if len(node.Env["ALLOW_MIXED_AFI_TRANSPORT"]) > 0 {
+                cmd += fmt.Sprintf(" --allow-mix-afi-transport")
+        }
+        if len(node.Env["LISTEN"]) > 0 {
+                cmd += fmt.Sprintf(" --listen %s")
+        }
+        if len(node.Env["LOCAL_AS"]) > 0 {
+                cmd += fmt.Sprintf(" --local-as %s", node.Env["LOCAL_AS"])
+        }
+        if len(node.Env["ROUTER_ID"]) > 0 {
+                cmd += fmt.Sprintf(" --router-id %s", node.Env["ROUTER_ID"])
+        }
+        if len(node.Env["PEER_AS"]) > 0 {
+                cmd += fmt.Sprintf(" --peer-as %s", node.Env["PEER_AS"])
+        }
+        if len(node.Env["MD5"]) > 0 {
+                cmd += fmt.Sprintf(" --md5 %s", node.Env["MD5"])
+        }
+        if len(node.Env["VLAN"]) > 0 {
+                cmd += fmt.Sprintf(" --vlan %s", node.Env["VLAN"])
+        }
+        if len(node.Env["TTL_SECURITY"]) > 0 {
+                cmd += fmt.Sprintf(" --ttl-security %s")
+        }
+
+        node.Cmd = cmd
+
+       return err
+}

[hellt]

@bdreisbach before looking into the code, I wonder what vr-bgp brings that you can't get with a regular containerized bgp daemon like gobgp or similar?

[bdreisbach]

i have a fairly large test suite already written that interfaces with vr-bgp.

[hellt]

Maybe you can get away with smth like this

node.Cmd = fmt.Sprintf("%s", node.Env["VRBGP_FLAGS"])

and then in your VRBGP_FLAGS env var you can pass all the needed flags

[hellt]

or maybe even easier would be to use cmd property of the node and just specify all flags there

[bdreisbach]

so, use kind: linux, the vr-bgp image and the cmd: thing to call "./vr-bgp.py $OPTIONS"?

[bdreisbach]

answered my own question by testing it. does indeed seem to work.

    ebgp-00:
      kind: linux
      image: vrnetlab/vr-bgp:latest
      cmd: "--router-id 100.0.0.1 --ipv4-prefix 1.1.1.0/31 --ipv6-prefix 2001:1::1:1:1:0/127 --local-as 100 --peer-as 200"

any interest in my vrnetlab patch to make this work?

[hellt]

Absolutely, thanks! Will you open a PR?

…

On Fri, 23 Apr 2021 at 23:06, bdreisbach ***@***.***> wrote: answered my own question by testing it. does indeed seem to work. ebgp-00: kind: linux image: vrnetlab/vr-bgp:latest cmd: "--router-id 100.0.0.1 --ipv4-prefix 1.1.1.0/31 --ipv6-prefix 2001:1::1:1:1:0/127 --local-as 100 --peer-as 200" any interest in my vrnetlab patch to make this work? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#404 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABLKV5IB5MKAW73CDCQCVR3TKHOONANCNFSM43O2QLFA> .

[bdreisbach]

will do. thanks!

[bdreisbach]

since i already have a fork of the main vrnetlab repo github wont let me fork your fork. unsure how to submit a PR in this scenario. i can just send you the diff if that works.

fwiw, i tested this in both bridge and non-bridged scenario which both work. i did not test every knob in vr-bgp though(vlan for example, but i do plan to at some point).

[hellt]

@bdreisbach what you can do in that case is the following

1. create a new empty repo under you account, i.e. clab-vrnetlab
2. clone this empty repo - git clone $repo-url
3. add hellt/vrnetlab repo as an upstream remote: git remote add upstream https://github.com/hellt/vrnetlab.git
4. pull the upstream master into your empty repo: git pull upstream master
5. do the changes required for vr-bgp
6. push them to clab-vrnetlab repo and create a PR from it