Skip to content

Latest commit

 

History

History
95 lines (70 loc) · 2.73 KB

cran-comments.md

File metadata and controls

95 lines (70 loc) · 2.73 KB
Raw

Resubmission:

This is a resubmission, which has incorporated the following changes:

  • Added Vincent van Hees as contributor in the Authors@R field of DESCRIPTION.

  • Added URL and BugReports fields to DESCRIPTION

  • Added a summary of what ActiGraph monitors measure in DESCRIPTION

  • Unwrapped examples from \dontrun{} where possible

  • Improved the documentation of classify_magnetometer()

  • Exported AG_meta()

  • Incremented version from 0.1.0 to 0.1.2 (An incomplete resubmission was mistakenly uploaded for version 0.1.1, but moved away before review at my request.)

Test environments

  • local Windows 10 install, R 3.4.3
  • ubuntu 14.04.5 (on travis-ci), R 3.4.4
  • win-builder (devel and release)

R CMD check results

There were no ERRORs or WARNINGs.

There was 1 NOTE:

  • checking CRAN incoming feasibility ... NOTE Maintainer: 'Paul R. Hibbing [email protected]'

New submission

Possibly mis-spelled words in DESCRIPTION: ActiGraph (2:29) accelerometer (10:27) pre (9:64)

This is the first submission of AGread. The first "possibly mis-spelled word" is the name of a device whose data are manipulated by the package functions. The other two words are false positives, "accelerometer" being a type of sensor, and "pre" being appended within the phrase "pre-processing."

Other comments

In addition to the new material supplied in this package, the following data sets and documentation are duplicated (or modifed) from the TwoRegression package, of which I am the author and maintainer:

  • imu_to_check
  • imu_to_collapse
  • raw_to_collapse

The following functions are duplicated (or modified) internal functions from the TwoRegression package:

  • get_minute
  • get_day_of_year
  • check_columns
  • check_second
  • get_raw_file_meta
  • get_imu_file_meta
  • AG_collapse
  • imu_collapse
  • imu_filter_gyroscope
  • classify_magnetometer
  • get_VM

The following functions are duplicated (or modified) exported functions from the TwoRegression package:

  • read_AG_IMU (re-named from read_IMU)
  • read_AG_raw

In retrospect, a standalone reading and pre-processing package (i.e., AGread) was always the best place for these functions and data sets to live. In the TwoRegression package, these items played a supporting role, whereas both packages will have a more focused purpose if the items are transitioned from TwoRegression to AGread. My plan for doing so would involve:

  • deprecating in the next submission of TwoRegression
  • removing, with a major version increment, in the subsequent of submission of TwoRegression

Reverse dependencies

There are currently no reverse dependencies for AGread. As implied above, TwoRegression will become a reverse dependency.