Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not autosuggest packages with dashes in names #310

Open
playpauseandstop opened this issue Feb 20, 2020 · 3 comments
Open

Do not autosuggest packages with dashes in names #310

playpauseandstop opened this issue Feb 20, 2020 · 3 comments
Labels
enhancement good for beginer Issue could be done without "specific" knowladge of plugin

Comments

@playpauseandstop
Copy link

First of all, this is awesome plugin! Thanks a lot for making it!

I'm using it everyday and in total highly happy with it results. However recently I found out one small issue and would like to consult, whether it should be fixed or not.

The issue is about package names with dashes and suggesting them for imports usage which makes no sense. Let's take a look on screenshot below,

Screen Shot 2020-02-20 at 14 48 53

It suggests to import from aiohttp-middlewares, but it will result in syntax error.

The source for suggestion is valid (from my pov), as aiohttp-middlewares named exactly as aiohttp-middlewares, but I believe SublimeJEDI should exclude that suggestions as they don't make much sense.

If this makes sense for you as well, I'll be glad to provide fix for given issue!

@srusskih srusskih added enhancement good for beginer Issue could be done without "specific" knowladge of plugin labels Feb 20, 2020
@playpauseandstop
Copy link
Author

BTW,

IPython, which also used JEDI for autosuggestion, do not suggest aiohttp-middlewares as seen at screenshot below,

Screen Shot 2020-02-20 at 21 30 09

@srusskih
Copy link
Owner

@playpauseandstop thanks for report.

@umairansar
Copy link

Could you please provide code reference which gathers entries for the autosuggestions list?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement good for beginer Issue could be done without "specific" knowladge of plugin
Projects
None yet
Development

No branches or pull requests

3 participants