-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TestNames test flaky #250
Comments
Related to #237. Keep forgetting to mention that. |
Interesting: the PASSes complete very quickly. The FAILs take more than 10 seconds. |
With these changes to try to narrow down where it's failing:
Some more failures:
So...my changes seemed to make no difference at all, because in all three of these cases, it failed for a different reason than the first one I posted. |
So, after making this change:
I get:
So...it was the first one published that worked. Maybe the |
After adding some logging statements in:
Wherever the 10 second delay's happening, it appears it's after the test has failed out. |
|
|
Some more failures, this time with logging the results we get back from the name check:
|
If you disable live index mode on sbot construction, the test consistently fails. |
Okay, so I think I've found part of the problem. The Line 187 in 3d08227
The problem is that when the messages are actually processed is here: Line 202 in 3d08227
But while new messages are being processed, |
Sensational Debugging Praxis @KyleMaas! Will dive into this later today 🥳 |
You can take a look at the code I was working with to generate those messages, so you can see where they're coming from, here: |
@KyleMaas seems to be back on the blink https://github.com/ssbc/go-ssb/actions/runs/3962165347 🤔 |
@decentral1se Yeah, I don't think I ever actually added the line to make the test wait for the indexes to catch up. |
Huh. No, the line is in there. I'll see if I can figure out what's going on. |
@decentral1se So...I've run this over 1500 times now with no failures. I'm not sure what would be different between the CI system and running it locally. About the only thing I can think of is maybe it hit that race condition in Margaret I was talking about over in #293 (comment) |
@KyleMaas yeh I can't seem to get a failure out of it and since it seems to be the original failure I also have a hunch it is CI caching? I will bust the cache and run the build again and see what happens. Let's keep this one for now anyway pending this and the Margaret thread... this test failure is putting up a real fight 😅 |
I think I found a way for this to still be happening. |
Lots of PASSes. But here's a FAIL:
The text was updated successfully, but these errors were encountered: