Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestSpec is not really flaky #275

Closed
KyleMaas opened this issue Dec 23, 2022 · 0 comments · Fixed by #276
Closed

TestSpec is not really flaky #275

KyleMaas opened this issue Dec 23, 2022 · 0 comments · Fixed by #276
Labels

Comments

@KyleMaas
Copy link
Contributor

See #237

You can't run the tests without cloning envelope-spec into the test directory:

=== RUN   TestSpec
    spec_test.go:29:
                Error Trace:    /home/go-ssb/go-ssb/private/box2/spec_test.go:29
                Error:          Received unexpected error:
                                open spec/vectors: no such file or directory
                Test:           TestSpec
                Messages:       open vectors dir
    spec_test.go:30: suggestion: run 'git clone https://github.com/ssbc/envelope-spec spec'
    spec_test.go:31: or clone it somewhere else and create a symlink to it here named 'spec'
--- FAIL: TestSpec (0.00s)
FAIL
FAIL    github.com/ssbc/go-ssb/private/box2     0.008s
FAIL

Not sure if there's a way to integrate this into the test suite or if the CI system downloads this when testing. Maybe this is why it was failing before? I ran it about 150 times and had zero failures once I downloaded envelope-spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging a pull request may close this issue.

2 participants