Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Add option for dictionary popup #695

Open
dcog989 opened this issue Apr 21, 2024 · 3 comments
Open

Feature request: Add option for dictionary popup #695

dcog989 opened this issue Apr 21, 2024 · 3 comments

Comments

@dcog989
Copy link

dcog989 commented Apr 21, 2024

I'm currently using https://github.com/meetDeveloper/Dictionary-Anywhere but it is not supported and has a few issues.

Would be nice to have this functionality in this extension? As per extension above, activated by user definable modifier key + double click.

@ssborbis
Copy link
Owner

ssborbis commented Apr 23, 2024

That might be too specific of a use case for this addon. I'm trying to think of how to make that functionality more broadly useful for other engines. Adding a way to display the popup is trivial, but each engine would need a custom script to parse the useful information or manage a REST API call. As of the latest version (1.46.25) there IS an option to display results in a popup window, (Open in Popup Window) but it's not especially robust at the moment.

@dcog989
Copy link
Author

dcog989 commented Apr 24, 2024

Yeah, I understand the "too specific" argument.
I quickly tried the popup option but didn't work for me - maybe I've changed a Firefox setting that affects it?
Hopefully you can think of an elegant solution that offers the functionality. :)

@ssborbis
Copy link
Owner

I quickly tried the popup option but didn't work for me - maybe I've changed a Firefox setting that affects it?

It may be a popup blocker issue. Although, I have my built-in blocker on, no exceptions, and can still get a popup window. YMMV

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants