Skip to content

Commit 04cd3fe

Browse files
committed
gerrit-push-for: Fix filtering unique reviewers
uniq only collapses adjacent duplicates, so we need to sort first.
1 parent affd54b commit 04cd3fe

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

gerrit/gerrit-push-for.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ if [ $skip -eq 0 ]; then
100100
if [ $? -eq 0 ]; then
101101
echo "Determining reviewers..."
102102
user=$(git config user.name)
103-
reviewers=$(git contacts $remote/$target..$ref 2> /dev/null | grep -iv "$user" | cut -d "<" -f 2 | cut -d ">" -f 1 | uniq)
103+
reviewers=$(git contacts $remote/$target..$ref 2> /dev/null | grep -iv "$user" | cut -d "<" -f 2 | cut -d ">" -f 1 | sort -u)
104104
if [ -f ~/gerrit-push-for.blacklist ]; then
105105
dos2unix -k ~/gerrit-push-for.blacklist 2> /dev/null
106106
reviewers=$(echo "$reviewers" | grep -vf ~/gerrit-push-for.blacklist)

0 commit comments

Comments
 (0)