Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Used libdesktop for wallpaper setting. #28

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

remggo
Copy link
Contributor

@remggo remggo commented Nov 4, 2016

As far as I can tell the MacOS Code should stay the same because of
the desktop Number specification in the MacOS Code, that is not used in libdesktop.

It would be nice if somebody with Windows can test if libdesktop works for them, I have no Windows where I can test that.

As far as I can tell the MacOS Code should stay the same because of
the desktop Number specification in this MacOS Code,
that is not used in libdesktop
@remggo
Copy link
Contributor Author

remggo commented Nov 4, 2016

Closes Issues #19 and #21 maybe also Issue #27

@bharadwaj-raju
Copy link

It would be nice if somebody with Windows can test if libdesktop works for them, I have no Windows where I can test that.

Works on Windows, can confirm.

@remggo
Copy link
Contributor Author

remggo commented Nov 5, 2016

Does this Pull Request work for you on Windows (I guess because your code is almost the same as ssimunics code)

@remggo remggo closed this Nov 5, 2016
@remggo remggo reopened this Nov 5, 2016
…f no argument was given. Added Option "--force": This Option can force an Image to be set as Wallpaper (Even if the Image already exists. Scenario: Change Wallpaper with this script. Change Wallpaper with Systemmethods. Try to change wallpaper with this script again -> it exits because the image is already saved. --> Add --force option and it will be set anyway)
@remggo remggo changed the title Used libdesktop for wallpaper setting. Used libdesktop for wallpaper setting. Fixed --nsfw boolean flag Nov 7, 2016
… False if no argument was given. Added Option "--force": This Option can force an Image to be set as Wallpaper (Even if the Image already exists. Scenario: Change Wallpaper with this script. Change Wallpaper with Systemmethods. Try to change wallpaper with this script again -> it exits because the image is already saved. --> Add --force option and it will be set anyway)"

This reverts commit b165096.
@remggo
Copy link
Contributor Author

remggo commented Nov 8, 2016

Sorry, I mixed up my branches. In this PR are commits for another PR which are already reverted on master.

@remggo remggo changed the title Used libdesktop for wallpaper setting. Fixed --nsfw boolean flag Used libdesktop for wallpaper setting. Nov 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants