-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Used libdesktop for wallpaper setting. #28
Open
remggo
wants to merge
3
commits into
ssimunic:master
Choose a base branch
from
remggo:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As far as I can tell the MacOS Code should stay the same because of the desktop Number specification in this MacOS Code, that is not used in libdesktop
Works on Windows, can confirm. |
Does this Pull Request work for you on Windows (I guess because your code is almost the same as ssimunics code) |
…f no argument was given. Added Option "--force": This Option can force an Image to be set as Wallpaper (Even if the Image already exists. Scenario: Change Wallpaper with this script. Change Wallpaper with Systemmethods. Try to change wallpaper with this script again -> it exits because the image is already saved. --> Add --force option and it will be set anyway)
remggo
changed the title
Used libdesktop for wallpaper setting.
Used libdesktop for wallpaper setting. Fixed --nsfw boolean flag
Nov 7, 2016
… False if no argument was given. Added Option "--force": This Option can force an Image to be set as Wallpaper (Even if the Image already exists. Scenario: Change Wallpaper with this script. Change Wallpaper with Systemmethods. Try to change wallpaper with this script again -> it exits because the image is already saved. --> Add --force option and it will be set anyway)" This reverts commit b165096.
Sorry, I mixed up my branches. In this PR are commits for another PR which are already reverted on master. |
remggo
changed the title
Used libdesktop for wallpaper setting. Fixed --nsfw boolean flag
Used libdesktop for wallpaper setting.
Nov 8, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell the MacOS Code should stay the same because of
the desktop Number specification in the MacOS Code, that is not used in libdesktop.
It would be nice if somebody with Windows can test if libdesktop works for them, I have no Windows where I can test that.