Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Article does not show up in Safari #260

Open
yuxin1234 opened this issue Nov 1, 2022 · 8 comments
Open

Article does not show up in Safari #260

yuxin1234 opened this issue Nov 1, 2022 · 8 comments

Comments

@yuxin1234
Copy link

Article does not show up in Safari, while it works fine in Chrome and Edge.
The error is "Invalid regular expression: invalid group specifier name"

Root cause: Safari doesn't support regex lookbehind. https://stackoverflow.com/questions/51568821/works-in-chrome-but-breaks-in-safari-invalid-regular-expression-invalid-group

@yuxin1234
Copy link
Author

@sstur could you please add me as a contributor to the repo? I'll create a PR to fix the issue.

@sstur
Copy link
Owner

sstur commented Nov 1, 2022

Hey @yuxin1234, thanks for offering to help. I believe you can make a PR without any special access, let me know if you run into any issues.

BTW, I think this issue was caused by #254, so feel free to make a PR to revert that, or if you have a solution that preserves the italic fix, even better. Thanks!

@sstur
Copy link
Owner

sstur commented Nov 1, 2022

Note: this issue was previously being tracked in #255.

@yuxin1234
Copy link
Author

@sstur Thanks. I have a fix that preserves the italic fix. I got this error when I did git push.
git push --set-upstream origin fixSafariDisplay
remote: Permission to sstur/draft-js-utils.git denied to yuxin1234.
fatal: unable to access 'https://github.com/sstur/draft-js-utils.git/': The requested URL returned error: 403
Please help. Thank you.

@sstur
Copy link
Owner

sstur commented Nov 1, 2022

Right. When making a PR to a public/open-source repo you'll need to fork it first.

@yuxin1234
Copy link
Author

@sstur Thanks. My first time contributing to a public repo. Will follow the instructions.

@yuxin1234
Copy link
Author

@sstur Please review #261. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants