-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Article does not show up in Safari #260
Comments
@sstur could you please add me as a contributor to the repo? I'll create a PR to fix the issue. |
Hey @yuxin1234, thanks for offering to help. I believe you can make a PR without any special access, let me know if you run into any issues. BTW, I think this issue was caused by #254, so feel free to make a PR to revert that, or if you have a solution that preserves the italic fix, even better. Thanks! |
Note: this issue was previously being tracked in #255. |
@sstur Thanks. I have a fix that preserves the italic fix. I got this error when I did git push. |
Right. When making a PR to a public/open-source repo you'll need to fork it first. |
@sstur Thanks. My first time contributing to a public repo. Will follow the instructions. |
Article does not show up in Safari, while it works fine in Chrome and Edge.
The error is "Invalid regular expression: invalid group specifier name"
Root cause: Safari doesn't support regex lookbehind. https://stackoverflow.com/questions/51568821/works-in-chrome-but-breaks-in-safari-invalid-regular-expression-invalid-group
The text was updated successfully, but these errors were encountered: