Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ValidatorRegistration Pre-Consensus Process to Include Fee Recipient #504

Open
olegshmuelov opened this issue Sep 19, 2024 · 1 comment

Comments

@olegshmuelov
Copy link
Contributor

olegshmuelov commented Sep 19, 2024

The ValidatorRegistration duty currently does not include the fee recipient, but instead relies on a dynamic duty struct for all duties. The fee recipient is taken from a state that can be modified by an event handler (FeeRecipientUpdate) during the pre-consensus process. This introduces the potential for a data race, which may result in the signing root of the ValidatorRegistration struct being altered. If this happens, the reconstruction of the partial signatures will fail, causing the duty itself to fail.

A refactor is needed to ensure that the fee recipient is handled safely within the ValidatorRegistration process, preventing race conditions and ensuring the consistency of the duty.

In #368 (comment), it was suggested to make independent structs for each duty type, which could be a more robust approach for preventing such issues.

@olegshmuelov
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant