Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E tests do not work #1994

Open
oleg-ssvlabs opened this issue Jan 21, 2025 · 0 comments
Open

E2E tests do not work #1994

oleg-ssvlabs opened this issue Jan 21, 2025 · 0 comments
Labels
bug Something isn't working tests Related to unit/integration tests

Comments

@oleg-ssvlabs
Copy link
Contributor

Currently, E2E tests do not work either in the pipeline or locally. It seems the last successful run was 10 months ago. Since the issue has been ignored for such a long time, I would raise the question of whether these tests provide any value. If they don’t, I suggest removing them entirely to reduce the maintainability burden. If they do provide value, they need to be fixed.

From a first glance, the issue appears to be:

  • E2E tests load the SSV Node Go module as a dependency.
  • SSV Node has been bumped to V2.
  • The SSV Node module path was not updated to reflect the V2, which is required (as per Go modules and major version changes). The module path should be updated to github.com/ssvlabs/ssv/v2 or so instead of github.com/ssvlabs/ssv.
  • Currently, V1 is installed in E2E, but V1's dependencies fail to load because one of the dependencies has changed its module name from github.com/bloxapp/eth2-key-manager to github.com/ssvlabs/eth2-key-manager.

The solution seems to be:

  1. Update the SSV Node module path to include /v2.
  2. Bump the dependency version to the latest in the E2E project.

Error message during Docker build:

 => ERROR [beacon_proxy prepare 4/4] RUN --mount=type=cache,target=/root/.cache/go-build     --mount=type=cache,mode=0755,target=/go/pkg     go mod download                                                                                 0.1s
------                                                                                                                                                                                                                                            
 > [beacon_proxy prepare 4/4] RUN --mount=type=cache,target=/root/.cache/go-build     --mount=type=cache,mode=0755,target=/go/pkg     go mod download:                                                                                            
0.134 go: github.com/ssvlabs/[email protected]: parsing go.mod:                                                                                                                                                                             
0.134 	module declares its path as: github.com/bloxapp/eth2-key-manager
[+] Running 0/1 but was required as: github.com/ssvlabs/eth2-key-manager
 ⠴ Service beacon_proxy  Building 
@oleg-ssvlabs oleg-ssvlabs added bug Something isn't working tests Related to unit/integration tests labels Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tests Related to unit/integration tests
Projects
None yet
Development

No branches or pull requests

1 participant