-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to omit collection in bulk insertions #113
Allow to omit collection in bulk insertions #113
Conversation
Same checks in item bulk insertions as in single insertions Added tests
Can't run tests locally, because I get this error in the docker build:
|
Linting error in gh actions. I'm not sure why you are getting that error? |
I'm pretty sure the error is due to some permission error if you use Docker, I would make sure there is no |
after talking with @ emmanuelmathot we agree that the collection_id is not needed for the items when submitting to the bulk items ingest endpoint 👍 thanks for the pr @constantinius 🙏 |
Related Issue(s):
Description:
Currently, each item in a bulk insertion must match the collection on which it is executed. This is different for single item insertions. Additionally, no check for the items ID and collection ID was performed, which is now rectified.
PR Checklist:
pre-commit
hooks pass locallymake test
)make docs
)