Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add log processing script to opa for decision logging #695

Merged
merged 13 commits into from
Jun 3, 2024

Conversation

xeniape
Copy link
Member

@xeniape xeniape commented May 27, 2024

Description

Part of stackabletech/opa-operator#422

This PR adds the script which is used in the opa start command set by the opa-operator to filter incoming logs by log level and route logs to the correct output (file or console).

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Tasks

TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

bake --product <product> --image-version <stackable-image-version>
kind load docker-image <image-tagged-with-the-major-version> --name=<name-of-your-test-cluster>

See the output of bake to retrieve the image tag for <image-tagged-with-the-major-version>.

Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice script. If you haven't already, it might pay to run it through the shellcheck linter.

opa/stackable/bin/process-logs Show resolved Hide resolved
opa/stackable/bin/process-logs Outdated Show resolved Hide resolved
sbernauer
sbernauer previously approved these changes May 27, 2024
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, exactly what I was thinking of! Haven't properly reviewed the operator part yet, feel free to wait with merge until both are ready to be merged.
Also happy about @siegfriedweber's review

opa/stackable/bin/process-logs Outdated Show resolved Hide resolved
opa/stackable/bin/process-logs Outdated Show resolved Hide resolved
opa/stackable/bin/process-logs Outdated Show resolved Hide resolved
@siegfriedweber siegfriedweber self-requested a review May 27, 2024 11:36
opa/stackable/bin/process-logs Outdated Show resolved Hide resolved
@xeniape xeniape requested a review from siegfriedweber May 29, 2024 10:07
Copy link
Member

@siegfriedweber siegfriedweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xeniape xeniape added this pull request to the merge queue Jun 3, 2024
Merged via the queue into main with commit 03ff53b Jun 3, 2024
13 checks passed
@xeniape xeniape deleted the feat-processing-log-messages branch June 3, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants