Apply suggestions from code review

Co-authored-by: Nick <[email protected]>
stackabletech · Dec 10, 2024 · ee48a9a · ee48a9a
1 parent d7a89c2
commit ee48a9a
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/template/.github/workflows/build.yml.j2 b/template/.github/workflows/build.yml.j2
@@ -347,7 +347,9 @@ jobs:
           bin: cargo-set-version
       - name: Update version if PR against main branch
         if: ${{ github.event_name == 'pull_request' && github.event.pull_request.base.ref == 'main' }}
-        run: cargo set-version --offline --workspace 0.0.0-pr${{ github.event.pull_request.number }}
+        env:
+          PR_NUMBER: ${{ github.event.pull_request.number }}
+        run: cargo set-version --offline --workspace 0.0.0-pr${PR_NUMBER}
       - name: Update version if PR against non-main branch
         # For PRs to be merged against a release branch, use the version that has already been set in the calling script.
         if: ${{ github.event_name == 'pull_request' && startsWith(github.event.pull_request.base.ref, 'release-') }}
@@ -422,7 +424,9 @@ jobs:
           bin: cargo-set-version
       - name: Update version if PR against main branch
         if: ${{ github.event_name == 'pull_request' && github.event.pull_request.base.ref == 'main' }}
-        run: cargo set-version --offline --workspace 0.0.0-pr${{ github.event.pull_request.number }}
+        env:
+          PR_NUMBER: ${{ github.event.pull_request.number }}
+        run: cargo set-version --offline --workspace 0.0.0-pr${PR_NUMBER}
       - name: Update version if PR against non-main branch
         # For PRs to be merged against a release branch, use the version that has already been set in the calling script.
         if: ${{ github.event_name == 'pull_request' && startsWith(github.event.pull_request.base.ref, 'release-') }}