Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation test is broken since quoted_printable 0.4.7 #122

Closed
link2xt opened this issue Jan 17, 2024 · 4 comments
Closed

Documentation test is broken since quoted_printable 0.4.7 #122

link2xt opened this issue Jan 17, 2024 · 4 comments

Comments

@link2xt
Copy link
Contributor

link2xt commented Jan 17, 2024

If I use quoted_printable = "=0.4.6" in Cargo.toml, all tests pass.

If I set quoted_printable = "=0.4.7" in Cargo.toml, one of the doc tests fails:

---- src/lib.rs - parse_mail (line 906) stdout ----
Test executable failed (exit status: 101).

stderr:
thread 'main' panicked at src/lib.rs:28:5:
assertion `left == right` failed
  left: "This is the plaintext version, in utf-8. Proof by Euro: €\r\n"
 right: "This is the plaintext version, in utf-8. Proof by Euro: €"
stack backtrace:
...

This is broken by the change staktrace/quoted-printable#16 it seems.

@link2xt link2xt changed the title Documentation test is broken since quoted_printable 0.4.6 Documentation test is broken since quoted_printable 0.4.7 Jan 17, 2024
@staktrace
Copy link
Owner

When I check out the master branch of mailparse, it has quoted-printable at version 0.4.8 and cargo tests --all and cargo test --doc both pass. What am I missing? And why does your PR use 0.4.6 as the base version that's being updated?

@staktrace
Copy link
Owner

Oh I see. I think you're using the latest tagged version rather than the master branch. This issue is a dup of #119 and has already been fixed. Maybe you just need me to tag a new release of mailparse?

@link2xt
Copy link
Contributor Author

link2xt commented Jan 17, 2024

Well, actually I want to update quoted_printable to 0.5.0 without duplicate dependencies: #123

@staktrace
Copy link
Owner

I publised v0.14.1 of mailparse with the updated quoted-printable dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants