Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test pathfinder for initialization with psis_resample=FALSE #1011

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

jgabry
Copy link
Member

@jgabry jgabry commented Jul 17, 2024

Submission Checklist

  • Run unit tests
  • Declare copyright holder and agree to license (see below)

Summary

Fixes #976. As pointed out by @wpetry, the test for using pathfinder for inits when psis_resample=FALSE was missing the psis_resample=FALSE.

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Columbia University

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

Copy link
Collaborator

@andrjohns andrjohns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jgabry jgabry merged commit c549ae6 into master Jul 18, 2024
11 checks passed
@jgabry jgabry deleted the fix-pathfinder-test branch July 18, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test for using pathfinder as init omits argument
2 participants