-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable jacobian argument for optimization #799
Conversation
I think this is ready for review. I put both @rok-cesnovar and @andrjohns as reviewers but this probably only needs one of you, it's not too complicated. |
Codecov Report
@@ Coverage Diff @@
## master #799 +/- ##
==========================================
- Coverage 88.27% 88.24% -0.03%
==========================================
Files 12 12
Lines 4152 4160 +8
==========================================
+ Hits 3665 3671 +6
- Misses 487 489 +2
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I'll work on #760 next |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Thanks for reviewing. Will merge now and continue working on the Laplace method in #800 |
Submission Checklist
Summary
Adds
jacobian
argument tooptimize
method.Closes #761 and paves the way for #760 (adding Laplace sample)
Copyright and Licensing
Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Columbia University
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses: