-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bind to "format document" key binding #9
Comments
No, I think it would be confusing when all those plugins automatically bind to the default |
Would you please consider making this configurable? |
@brucx haha, I don't find any free time to implement this. You can submit a pull request if you like, I'm willing to merge it. |
How would that be different from now? The user can just bind the Formatting Hotkey to JS Fix Problems and has the same effect !? |
https://code.visualstudio.com/blogs/2016/11/15/formatters-best-practices The problem with creating a user shortcut is that is not easily shared between platforms (see Settings Sync) and other developers (shared projects). It would be much nicer to have a proper formatter. |
I do not understand. All the extensions I have used (Rust, C++, Java, Python) just plug in into the API – why should this extension be different? VSCode already provides settings to configure formatters per language. |
Annoyingly the extension for VSCode doesn't hook into the standard formatting API but instead uses it's own key bindings so you cannot set it to format when pressing the format hotkey. Auto fix on save will have to do for now. Discussion on the issue tracker here: standard/vscode-standard#9
Should this plugin automatically bind to the default "format document" key binding?
(It works just fine in chenxsan.vscode-standard-format)
The text was updated successfully, but these errors were encountered: