Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(web) Confusion regarding theme selection and system color scheme in Standard Notes Web App #3845

Open
besdar opened this issue Jan 4, 2025 · 0 comments
Labels

Comments

@besdar
Copy link

besdar commented Jan 4, 2025

Describe the bug
Upon my first visit to the Standard Notes web app at night, I was taken aback by the bright white theme. When I accessed the theme changer, I noticed that the "Default" theme was already selected, which left me puzzled as to why there were only "Default" and "Dark" themes available, with no "White" theme present. Additionally, the "Default" theme did not align with my system's theme settings.

I also observed a "Use system color scheme" toggle in the app's settings, which appears to correspond to the "Default" theme that respects my system's preferences. However, when this toggle is enabled and I make a selection in the "Appearance" quick menu, my choice seems irrelevant, as it resets upon the next page load. This raises the question: why is there an option to select a theme if it does not persist? Furthermore, why is this menu not disabled when the "Use system color scheme" toggle is in use? This situation is quite confusing.

To Reproduce
Steps to reproduce the behavior:

  1. Set your device to a dark theme or configure the dark color theme in the browser's web developer tools.
  2. Navigate to https://app.standardnotes.com/.
  3. Observe that the white theme is displayed.

Expected behavior
The dark theme should be applied.

Screenshots
image
image

Desktop (please complete the following information):

  • OS: any
  • Browser: any
  • Version: 3.195.14

Smartphone (please complete the following information):

  • Device: any
  • OS: any
  • Browser: any
  • Version: 3.195.14

Additional context
I recommend creating a distinct "White" theme option in the theme selection menu, removing the potentially confusing "Use system color scheme" toggle from the settings, and replacing it with a "Default" item in the theme selection. On the initial load, the "Default" theme should be selected to align with the user's system theme, which can then be overridden by the user's selection in the "Appearance" quick menu.

I would be happy to assist with this and open a pull request myself, but I need to ensure that these functionality changes are approved in advance, as they would require significant modifications to the code. I want to avoid investing time in something that may not be accepted. Thank you for considering this feedback!

@besdar besdar added the bug label Jan 4, 2025
@besdar besdar changed the title (web) Confusion Regarding Theme Selection and System Color Scheme in Standard Notes Web App (web) Confusion regarding theme selection and system color scheme in Standard Notes Web App Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant