Less contention in tokenization #893
Merged
+106
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -37,14 +37,16 @@ async def test_list_async_dataset_appends_and_finalizes_correctly(): | |||
|
|
|||
There was a problem hiding this comment.
This test seems to be for a different issue (i.e., is shuffle working) than contention in tokenization?
There was a problem hiding this comment.
yeah sorry it snuck in. dont' care enough to fix it.
RohithKuditipudi
requested review from
RohithKuditipudi
and removed request for
RohithKuditipudi
RohithKuditipudi
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully avoiding the $$$ we've seen tokenizing