Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It is not possible to update devices if the new versions has new functions #40

Open
gcampax opened this issue Jun 12, 2019 · 0 comments
Open

It is not possible to update devices if the new versions has new functions #40

gcampax opened this issue Jun 12, 2019 · 0 comments
Labels
bug

Comments

@gcampax
Copy link
Contributor

gcampax commented Jun 12, 2019

Trying to open the page in My Skills fails with "Class XXXX has no query YYYY" (probably while typechecking the new examples)
@gcampax gcampax added the bug label Jun 12, 2019
gcampax added a commit to stanford-oval/thingtalk that referenced this issue Mar 7, 2021
@gcampax
SchemaRetreiver: typecheck dataset examples individually
21fff41 
In certain cases, the dataset can fail to typecheck as a whole
because there are examples with newer functions or wrong parameters.
This can occur if a device has been updated recently (in the last
3 hours), or can occur for a builtin device if Genie or the platform
layers have not been updated yet.
In that case, we should ignore and log the error, and let as many
examples through as we can.

Fixes stanford-oval/thingpedia-common-devices#286
and will probably help with stanford-oval/almond-gnome#40
@gcampax gcampax mentioned this issue Mar 7, 2021
Merged
gcampax added a commit to stanford-oval/thingtalk that referenced this issue Mar 7, 2021
@gcampax
SchemaRetreiver: typecheck dataset examples individually (#324)
ab4e054 
In certain cases, the dataset can fail to typecheck as a whole
because there are examples with newer functions or wrong parameters.
This can occur if a device has been updated recently (in the last
3 hours), or can occur for a builtin device if Genie or the platform
layers have not been updated yet.
In that case, we should ignore and log the error, and let as many
examples through as we can.

Fixes stanford-oval/thingpedia-common-devices#286
and will probably help with stanford-oval/almond-gnome#40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gcampax