Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home Assistant: Repeated "light off" response #193

Open
spacegaier opened this issue May 11, 2021 · 2 comments
Open

Home Assistant: Repeated "light off" response #193

spacegaier opened this issue May 11, 2021 · 2 comments
Labels
P2 We need to fix it (backlog)

Comments

@spacegaier
Copy link
Contributor

Latest Almond Edge HA add-on:

Q: which lights are on?
A: Your lights are off. Your lights are off. Your lights are off. Your lights are off. Your lights are off.

grafik

=> Repeated answer, plus incorrect since some lights were on.

@gcampax
Copy link
Contributor

gcampax commented May 11, 2021

Thanks for the report! It's expected to include the name of each lightbulb in each answer. Something along the lines of:
"Your Corner lamp top lights are on. Your Corner lamp mid lights are off. Your Corner lamp bottom lights are off. Your Living Room lights are on."
I filed stanford-oval/thingpedia-common-devices#336 to fix this.

@spacegaier
Copy link
Contributor Author

spacegaier commented May 11, 2021

@gcampax That is however only part of the problem. The response itself is not complete or correct. I have around 30 lights in HA and all of those I can see as skills in Almond. When I ask "which lights are on?" it attempts to list 5 ones (thanks to your PR soon with the actual name), but those are all off.

So I think there are two things here:

  1. If I ask for switched on lights, it seems to respond with switched off ones.
  2. If the logic is to only list the first five matching devices in case a command matches more than that, then it would be helpful if the output mentioned that there are X others.
  3. Perhaps explained by point 2: I currently have one light switched on (via Almond), but still the command mentions only switched off lights. Could be a state detection issue or just the fact that not all light devices are listed in the response and if more were, the actually switched on one would have been marked as switched on. If the output is just completely inverted currently (point 1) then this would be another explanation.

@nrser nrser added the P2 We need to fix it (backlog) label Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 We need to fix it (backlog)
Projects
None yet
Development

No branches or pull requests

3 participants