Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle "unique" params in filters #105

Open
sileix opened this issue Jul 11, 2019 · 2 comments
Open

Correctly handle "unique" params in filters #105

sileix opened this issue Jul 11, 2019 · 2 comments
Assignees
Labels
bug P2 We need to fix it (backlog)

Comments

@sileix
Copy link
Member

sileix commented Jul 11, 2019

Currently, once a unique param is used in filter, the table is marked as no_filter, i.e., no more filter can be added to it. However, in some cases, this is not reasonable:

  1. or operator: this should always be allowed even if unique param is used
  2. not operator on unique param: this should turn the filter to be not unique (?)
@gcampax
Copy link
Contributor

gcampax commented Jul 11, 2019

Also, if the filter value is not a constant

@sileix
Copy link
Member Author

sileix commented Jul 11, 2019

Also, if the operand is not "equal"

@gcampax gcampax added the bug label Jul 11, 2019
@nrser nrser added the P2 We need to fix it (backlog) label Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug P2 We need to fix it (backlog)
Projects
None yet
Development

No branches or pull requests

3 participants