Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimization for boolean questions #367

Open
sileix opened this issue Jul 19, 2021 · 1 comment
Open

Optimization for boolean questions #367

sileix opened this issue Jul 19, 2021 · 1 comment
Assignees
Labels
P2 We need to fix it (backlog)

Comments

@sileix
Copy link
Member

sileix commented Jul 19, 2021

the booleanExpression in the boolean questions is currently not optimized. E..g, in the case when it's statically true/false, we could simply use [true]/[false] to avoid the computation, or even avoid running the query entirely.

@sileix sileix self-assigned this Jul 19, 2021
@gcampax
Copy link
Contributor

gcampax commented Jul 20, 2021

Yeah you'll want to add the filter optimization right away because it also normalizes the filters and sorts it by parameter name, which you need for training.

@nrser nrser added the P2 We need to fix it (backlog) label Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 We need to fix it (backlog)
Projects
None yet
Development

No branches or pull requests

3 participants