Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differences between paper and code #3

Open
nguyenhungquang opened this issue May 31, 2022 · 0 comments
Open

Differences between paper and code #3

nguyenhungquang opened this issue May 31, 2022 · 0 comments

Comments

@nguyenhungquang
Copy link

nguyenhungquang commented May 31, 2022

Hi,
While reading your code, I realized some slight differences between your algorithm in the paper and what was implemented here, and found it really difficult to understand, could you help me to clarify?

  • In the paper, barcodes at different values of a factor are combined by Wasserstein barycenter. However, function barymean here computes between different runs of RLT algorithm at a specific value (which are totally different because we are using witness complex). And in this repo barcodes at different values of a factor are aggregated by simple mean operator (as shown in here).
  • The formulation of (unsupervised) evaluation metric is $\mu = \rho_c - \rho_{\c}$, in which $\rho_c$ are summation of W distance of mean barcodes of different factor in a same cluster, and $\rho_{\c}$ are those at different clusters minus $\rho_c$. When I look at bicluster_score function, it seems to be $\rho_{\c}$ only, which makes me really confused.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant