Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Agent's image repository and tag are hardcoded #33

Closed
starbops opened this issue Nov 10, 2024 · 1 comment
Closed

[BUG] Agent's image repository and tag are hardcoded #33

starbops opened this issue Nov 10, 2024 · 1 comment
Assignees
Labels
component/manager Relevant to the custom Kubernetes controllers kind/bug Something isn't working

Comments

@starbops
Copy link
Owner

Describe the bug

virtbmc's image name and tag are hardcoded to starbops/virtbmc and dev no matter what KubeVirtBMC version is installed.

To Reproduce
Steps to reproduce the behavior:

  1. Create a Kubernetes cluster
  2. Install KubeVirt
  3. Install cert-manager
  4. Install KubeVirtBMC via make deploy
  5. Create a virtual machine
  6. The created virtbmc Pod will use the starbops/virtbmc:dev container image

Expected behavior

The image name and tag should follow the controller's by default and be configurable via the controller's flags to allow customization.

Screenshots

N/A

Environment (please complete the following information):

  • OS: Harvester v1.3.2
  • Kubernetes version: v1.28.12+rke2r1
  • KubeVirt version: v1.1.1
  • KubeVirtBMC version: v0.3.1

Additional context

First found in #19 (comment)

@starbops starbops added the kind/bug Something isn't working label Nov 10, 2024
@starbops starbops moved this to Ready in KubeVirtBMC project Nov 11, 2024
@starbops starbops moved this from Ready to In review in KubeVirtBMC project Nov 18, 2024
@starbops
Copy link
Owner Author

Close as fixed in #37 and #38.

@github-project-automation github-project-automation bot moved this from In review to Done in KubeVirtBMC project Nov 18, 2024
@starbops starbops self-assigned this Nov 18, 2024
@starbops starbops added the component/manager Relevant to the custom Kubernetes controllers label Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/manager Relevant to the custom Kubernetes controllers kind/bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

1 participant