Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

createVectorIndex has unwanted restrictions on the source model name #1674

Open
amorton opened this issue Nov 10, 2024 · 2 comments · May be fixed by #1815
Open

createVectorIndex has unwanted restrictions on the source model name #1674

amorton opened this issue Nov 10, 2024 · 2 comments · May be fixed by #1815
Assignees
@Hazel-Datastax
Labels
Bug Something isn't working To-Do

Comments

@amorton
Copy link
Contributor

amorton commented Nov 10, 2024

This is on the options for create index

      @Nullable
          @Size(min = 1, max = 48)
          @Pattern(regexp = "[a-zA-Z][a-zA-Z0-9_]*")
          @Schema(description = "Model name used to generate the embeddings.")
          @JsonInclude(JsonInclude.Include.NON_NULL)
          String sourceModel) {}

Why does it limit the characters and the length ?

it looks like this has been copy - pasted into many places:

        @Size(min = 1, max = 48)
        @Pattern(regexp = "[a-zA-Z][a-zA-Z0-9_]*")

This ticket should also check all the places this is present to see if it should be there.
@amorton amorton added the Bug Something isn't working label Nov 10, 2024
@amorton amorton added the To-Do label Dec 11, 2024
@amorton
Copy link
Contributor Author

amorton commented Dec 11, 2024

we can remove it from the sourceModel param, and check other places where this size and reg exp pattern are used . Remove any we obviously know should not be there.

@amorton
Copy link
Contributor Author

amorton commented Dec 11, 2024

discussions:

  • commands like DropTable should not limit the name of the table to drop, we should be limiting on the create
  • the ColumnsDescContainer needs a deserialiser so we can check the name of the columns :(

@Hazel-Datastax Hazel-Datastax self-assigned this Dec 23, 2024
This was referenced Jan 2, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Hazel-Datastax Hazel-Datastax

Labels
Bug Something isn't working To-Do
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove restrictions on different names stargate/data-api
3 participants
@amorton @maheshrajamani @Hazel-Datastax