Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix field "title" and related field in the RPC specs #575

Closed
ivpavici opened this issue Apr 6, 2023 · 7 comments
Closed

Fix field "title" and related field in the RPC specs #575

ivpavici opened this issue Apr 6, 2023 · 7 comments
Assignees
Labels
OnlyDust Open for OnlyDust contributors Type: feature New feature or request

Comments

@ivpavici
Copy link
Collaborator

ivpavici commented Apr 6, 2023

Not in starknet.js code, but very related issue: starkware-libs/starknet-specs#81 (comment)

Which fixing would help further development of future RPC versions, for example: #574

Estimated time to fix is couple of hours work

@ivpavici ivpavici added Type: feature New feature or request OnlyDust Open for OnlyDust contributors labels Apr 6, 2023
@ivpavici
Copy link
Collaborator Author

ivpavici commented May 3, 2023

merged:
starkware-libs/starknet-specs#84

@notV4l
Copy link
Contributor

notV4l commented May 3, 2023

i can have a look at it

@notV4l
Copy link
Contributor

notV4l commented May 4, 2023

autogeneration issues :
starkware-libs/starknet-specs#87

@ivpavici
Copy link
Collaborator Author

ivpavici commented May 4, 2023

@tabaktoni is the issue created by @notV4l relevant to us?

@tabaktoni
Copy link
Collaborator

From the issue, It look like rpc schema is not valid as so it is relevant to everyone

@notV4l
Copy link
Contributor

notV4l commented May 4, 2023

attempt to fix some issues : starkware-libs/starknet-specs#88

@ivpavici
Copy link
Collaborator Author

ivpavici commented May 5, 2023

We must do additional work on the rpc specs, so we can close this one for now. The work already done will help with the new RPC changes, but still manual modification will be needed for the time being

@ivpavici ivpavici closed this as completed May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OnlyDust Open for OnlyDust contributors Type: feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants