Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

casing: Starknet instead of StarkNet #705

Closed
pscott opened this issue Aug 2, 2023 · 10 comments · Fixed by #723
Closed

casing: Starknet instead of StarkNet #705

pscott opened this issue Aug 2, 2023 · 10 comments · Fixed by #723
Labels
discussion needed OnlyDust Open for OnlyDust contributors Type: feature New feature or request

Comments

@pscott
Copy link

pscott commented Aug 2, 2023

Is your feature request related to a problem? Please describe.
The official casing for Starknet is not StarkNet anymore, but Starknet.
However, some occurrences of StarkNet can still be found, most notably in the TypeHash function:
https://github.com/0xs34n/starknet.js/blob/384db9f3bfaf066dea43f60e49f255c9a4a28b63/src/utils/typedData.ts#L255-L256

Describe the solution you'd like
Replace every occurence of StarkNet with Starknet

Describe alternatives you've considered
Keep StarkNet and dismiss this issue. I think it's still early enough to change to Starknet though.

Additional notes
This introduces a big breaking change (:

@pscott pscott added the Type: feature New feature or request label Aug 2, 2023
@0xdorifto
Copy link
Contributor

Hey! Can this issue be assigned to me?

@tabaktoni tabaktoni added the OnlyDust Open for OnlyDust contributors label Aug 10, 2023
@tabaktoni
Copy link
Collaborator

@0xdorifto Yes feel free to take it

@0xdorifto
Copy link
Contributor

@tabaktoni thanks! I'll start working on it now.

@pscott
Copy link
Author

pscott commented Aug 11, 2023

@0xdorifto Yes feel free to take it

should we discuss if it's worth introducing the breaking change?

@PhilippeR26
Copy link
Collaborator

PhilippeR26 commented Aug 12, 2023

Not sure it's still early enough to change.
Should be first validated by ArgentX, Braavos, ...

@0xdorifto
Copy link
Contributor

It's up here if you guys want to check it out ^

@ivpavici ivpavici linked a pull request Aug 17, 2023 that will close this issue
6 tasks
@ivpavici
Copy link
Collaborator

@janek26 @dhruvkelawala @yoga-braavos can you please give your input about this? 🙏

@ivpavici
Copy link
Collaborator

Will probably be able to close this after this one is closed starknet-io/get-starknet#194

@PhilippeR26
Copy link
Collaborator

Will at the end be defined by this snip : https://community.starknet.io/t/snip-off-chain-signatures-a-la-eip712/98029#abstract-1

@tabaktoni
Copy link
Collaborator

Resolved in favor of the snip, for further progress push change's on the snip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion needed OnlyDust Open for OnlyDust contributors Type: feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants