-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
casing: Starknet
instead of StarkNet
#705
Comments
Hey! Can this issue be assigned to me? |
@0xdorifto Yes feel free to take it |
@tabaktoni thanks! I'll start working on it now. |
should we discuss if it's worth introducing the breaking change? |
Not sure it's still early enough to change. |
It's up here if you guys want to check it out ^ |
@janek26 @dhruvkelawala @yoga-braavos can you please give your input about this? 🙏 |
Will probably be able to close this after this one is closed starknet-io/get-starknet#194 |
Will at the end be defined by this snip : https://community.starknet.io/t/snip-off-chain-signatures-a-la-eip712/98029#abstract-1 |
Resolved in favor of the snip, for further progress push change's on the snip |
Is your feature request related to a problem? Please describe.
The official casing for
Starknet
is notStarkNet
anymore, butStarknet
.However, some occurrences of
StarkNet
can still be found, most notably in the TypeHash function:https://github.com/0xs34n/starknet.js/blob/384db9f3bfaf066dea43f60e49f255c9a4a28b63/src/utils/typedData.ts#L255-L256
Describe the solution you'd like
Replace every occurence of
StarkNet
withStarknet
Describe alternatives you've considered
Keep
StarkNet
and dismiss this issue. I think it's still early enough to change toStarknet
though.Additional notes
This introduces a big breaking change (:
The text was updated successfully, but these errors were encountered: