fix: update revision type (#5)

future versions 1+ should be only string. The type should be kept as shortstring, but the value should be passed as 1 instead of ‘1’, Just for revision 1
starknet-io · Jun 4, 2024 · 2d7a0d5 · 2d7a0d5
1 parent f78f0d4
commit 2d7a0d5
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/wallet-api/typedData.ts b/src/wallet-api/typedData.ts
@@ -39,7 +39,7 @@ export interface StarknetDomain extends Record<string, unknown> {
   name?: string;
   version?: string;
   chainId?: string | number; // TODO: check resolution, diverge from SPEC and follow SNIP-12
-  revision?: string;
+  revision?: string | number; // TODO: future versions 1+ should be only string. The type should be kept as shortstring, but the value should be passed as 1 instead of ‘1’, Just for revision 1
 }
 
 /**