From 2d7a0d575ab2b95c1e96125f4fb385613a721fdf Mon Sep 17 00:00:00 2001 From: Toni Tabak Date: Tue, 4 Jun 2024 12:00:51 +0200 Subject: [PATCH] fix: update revision type (#5) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit future versions 1+ should be only string. The type should be kept as shortstring, but the value should be passed as 1 instead of ‘1’, Just for revision 1 --- src/wallet-api/typedData.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/wallet-api/typedData.ts b/src/wallet-api/typedData.ts index 0181cdf..a0c892d 100644 --- a/src/wallet-api/typedData.ts +++ b/src/wallet-api/typedData.ts @@ -39,7 +39,7 @@ export interface StarknetDomain extends Record { name?: string; version?: string; chainId?: string | number; // TODO: check resolution, diverge from SPEC and follow SNIP-12 - revision?: string; + revision?: string | number; // TODO: future versions 1+ should be only string. The type should be kept as shortstring, but the value should be passed as 1 instead of ‘1’, Just for revision 1 } /**