feat(gateway): add fee non zero validation

[ArniStarkware]

This change is 

[elintul]

Reviewed all commit messages.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @ArniStarkware and @dafnamatsry)

---

crates/gateway/src/transaction_validator.rs line 35 at r1 (raw file):

    pub max_allowed_tx_version: TransactionVersion,

    pub enforce_fee: bool,

I think in Python we only use this flag for testing.

Code quote:

enforce_fee

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 92.72727% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 88.46%. Comparing base (60b6092) to head (b2dcffd).

Files	Patch %	Lines
crates/gateway/src/starknet_api_utils.rs	93.44%	4 Missing ⚠️
crates/gateway/src/transaction_validator.rs	91.83%	1 Missing and 3 partials ⚠️

Additional details and impacted files

@@                                Coverage Diff                                @@
##           arni/transaction_validator/stateless/skelaton      #12      +/-   ##
=================================================================================
+ Coverage                                          83.70%   88.46%   +4.75%     
=================================================================================
  Files                                                  4        4              
  Lines                                                135      234      +99     
  Branches                                             135      234      +99     
=================================================================================
+ Hits                                                 113      207      +94     
- Misses                                                20       22       +2     
- Partials                                               2        5       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ArniStarkware]

Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @dafnamatsry and @elintul)

---

crates/gateway/src/transaction_validator.rs line 35 at r1 (raw file):

Previously, elintul (Elin) wrote…

I think in Python we only use this flag for testing.

Removed. If it is required, we will add it later.

[dafnamatsry]

Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions (waiting on @ArniStarkware and @elintul)

---

crates/gateway/src/starknet_api_utils.rs line 57 at r4 (raw file):

impl TransactionParametersExt for Transaction {
    fn max_fee(&self) -> StarknetApiTransactionResult<Fee> {

I think it is getting too complicated with macros and many trait extensions.

Consider the following:

let resource_bounds = match self {
  StarknetApiTransaction::Declare(
                starknet_api::transaction::DeclareTransaction::V0(_)
                | starknet_api::transaction::DeclareTransaction::V1(_)
                | starknet_api::transaction::DeclareTransaction::V2(_),
            ) => unimplemented!(),
  Transaction::Declare(DeclareTransaction::V3(tx)) => tx.resource_bounds,
  ...
}

... compute max_fee from resource_bounds ...

Ok(max_fee)

[ArniStarkware]

Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions (waiting on @dafnamatsry and @elintul)

---

crates/gateway/src/starknet_api_utils.rs line 57 at r4 (raw file):

Previously, dafnamatsry wrote…

I think it is getting too complicated with macros and many trait extensions.

Consider the following:

let resource_bounds = match self {
  StarknetApiTransaction::Declare(
                starknet_api::transaction::DeclareTransaction::V0(_)
                | starknet_api::transaction::DeclareTransaction::V1(_)
                | starknet_api::transaction::DeclareTransaction::V2(_),
            ) => unimplemented!(),
  Transaction::Declare(DeclareTransaction::V3(tx)) => tx.resource_bounds,
  ...
}

... compute max_fee from resource_bounds ...

Ok(max_fee)

I reordered the PRs.
(This PR sitis on top of #15 now).

Now, the macro infrastructure is cleaner, smaller and clearer.

[ArniStarkware]

replaced with: #29