test: generalize resource bounds related tests #45
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #45 +/- ##
==========================================
- Coverage 64.64% 63.15% -1.49%
==========================================
Files 5 5
Lines 99 95 -4
Branches 99 95 -4
==========================================
- Hits 64 60 -4
Misses 35 35 ☔ View full report in Codecov by Sentry. |
ArniStarkware
force-pushed
the
arni/transaction_validator/stateless/tests/resource_bounds_mapping_param
branch
3 times, most recently
from
10103bb to
a9a28ee
Compare
ArniStarkware
changed the title
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArniStarkware and @dafnamatsry)
crates/gateway/src/starknet_api_test_utils.rs line 66 at r2 (raw file):
} pub const NON_EMPTY_RSOURCE_BOUNDS: ResourceBounds = ResourceBounds {
RESOURCE
Code quote:
RSOURCE
ArniStarkware
force-pushed
the
arni/transaction_validator/stateless/tests/resource_bounds_mapping_param
branch
from
a9a28ee to
484c7fc
Compare
There was a problem hiding this comment.
Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on @dafnamatsry and @Yael-Starkware)
crates/gateway/src/starknet_api_test_utils.rs line 66 at r2 (raw file):
Previously, Yael-Starkware (YaelD) wrote…
RESOURCE
Done.
There was a problem hiding this comment.
Reviewed 2 of 2 files at r3.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @dafnamatsry)
There was a problem hiding this comment.
Reviewed 1 of 3 files at r1, 2 of 2 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)
ArniStarkware
deleted the
arni/transaction_validator/stateless/tests/resource_bounds_mapping_param
branch
This change is