feat: add compile sierra to casm util #493
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArniStarkware
force-pushed
the
arni/sierra_to_casm/use_executable/try_5
branch
from
8361d0c to
9f7e1d5
Compare
ArniStarkware
changed the base branch from
main
to
arni/chore/starknet_sierra_compile/fix_get_abs_path
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ArniStarkware and the rest of your teammates on |
This was referenced Jul 17, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## arni/chore/starknet_sierra_compile/fix_get_abs_path #493 +/- ##
=======================================================================================
+ Coverage 83.38% 83.58% +0.19%
=======================================================================================
Files 37 37
Lines 1782 1803 +21
Branches 1782 1803 +21
=======================================================================================
+ Hits 1486 1507 +21
Misses 218 218
Partials 78 78 ☔ View full report in Codecov by Sentry. |
|
The tests tend to fail sporadically. Need to check. |
ArniStarkware
force-pushed
the
arni/chore/starknet_sierra_compile/fix_get_abs_path
branch
from
b00b20b to
77398c0
Compare
ArniStarkware
force-pushed
the
arni/sierra_to_casm/use_executable/try_5
branch
from
9f7e1d5 to
7d36848
Compare
ArniStarkware
force-pushed
the
arni/chore/starknet_sierra_compile/fix_get_abs_path
branch
from
77398c0 to
71013e9
Compare
ArniStarkware
force-pushed
the
arni/sierra_to_casm/use_executable/try_5
branch
from
7d36848 to
010f9fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See many important comments on #24.
Also - there were interesting discussions on #35.
This change is