refactor(network): db executor is removed from NetworkManager and runs in a separate task

[ShahakShama]

• refactor(network): remove Data from db executor
• refactor(network): db executor communicates through channels
• refactor(network): db executor is removed from NetworkManager and runs in a separate task

---

This change is 

[codecov]

Codecov Report

Attention: Patch coverage is 24.24242% with 50 lines in your changes missing coverage. Please review.

Project coverage is 64.31%. Comparing base (bb9be89) to head (161c1cc).

❗ Current head 161c1cc differs from pull request most recent head a736497

Please upload reports for the commit a736497 to get more accurate results.

Files	Patch %	Lines
crates/papyrus_network/src/network_manager/mod.rs	0.00%	27 Missing ⚠️
crates/papyrus_node/src/main.rs	28.12%	22 Missing and 1 partial ⚠️

Additional details and impacted files

@@                       Coverage Diff                       @@
##           shahak/db_executor_channels    #2122      +/-   ##
===============================================================
- Coverage                        64.37%   64.31%   -0.07%     
===============================================================
  Files                              136      136              
  Lines                            17941    17900      -41     
  Branches                         17941    17900      -41     
===============================================================
- Hits                             11550    11512      -38     
  Misses                            5113     5113              
+ Partials                          1278     1275       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[eitanm-starkware]

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ShahakShama)

[matan-starkware]

Reviewed 4 of 7 files at r1, 1 of 2 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @ShahakShama)

---

crates/papyrus_network/src/db_executor/mod.rs line 79 at r3 (raw file):

    StateDiffResponsesSender:
        Sink<DataOrFin<StateDiffChunk>, Error = SendError> + Unpin + Send + 'static,
{

These go over 100 columns. Should we use subtypes type Y = XXX

Code quote:

where
    HeaderQueryReceiver: Stream<Item = (Result<HeaderQuery, ProtobufConversionError>, HeaderResponsesSender)>
        + Unpin,
    HeaderResponsesSender:
        Sink<DataOrFin<SignedBlockHeader>, Error = SendError> + Unpin + Send + 'static,
    StateDiffQueryReceiver: Stream<Item = (Result<StateDiffQuery, ProtobufConversionError>, StateDiffResponsesSender)>
        + Unpin,
    StateDiffResponsesSender:
        Sink<DataOrFin<StateDiffChunk>, Error = SendError> + Unpin + Send + 'static,
{

---

crates/papyrus_network/src/db_executor/test.rs line 171 at r3 (raw file):

            Sender<DataOrFin<StateDiffChunk>>,
        )>,
    >,

type TestDbExecutor = ...

Code quote:

    DBExecutor<
        Receiver<(
            Result<HeaderQuery, ProtobufConversionError>,
            Sender<DataOrFin<SignedBlockHeader>>,
        )>,
        Receiver<(
            Result<StateDiffQuery, ProtobufConversionError>,
            Sender<DataOrFin<StateDiffChunk>>,
        )>,
    >,

---

crates/papyrus_node/src/main.rs line 143 at r3 (raw file):

    .await?;

    // P2P Sync Server task.

Why do you specify p2p?

Code quote:

    // P2P Sync Server task.

[ShahakShama]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @matan-starkware)

---

crates/papyrus_network/src/db_executor/mod.rs line 79 at r3 (raw file):

Previously, matan-starkware wrote…

These go over 100 columns. Should we use subtypes type Y = XXX

This is not a type, it's a type bound. type bound aliases is an experimental feature in rust
But we plan to remove these generics once we create a test utility for sync like the one Asmaa created today for consensus

---

crates/papyrus_network/src/db_executor/test.rs line 171 at r3 (raw file):

Previously, matan-starkware wrote…

type TestDbExecutor = ...

This is the only place we define it, so I see no reason to create a type alias

---

crates/papyrus_node/src/main.rs line 143 at r3 (raw file):

Previously, matan-starkware wrote…

Why do you specify p2p?

Because there's a central sync (It doesn't have a server, but we want to connect this to the p2p sync client)

[matan-starkware]

Reviewed 6 of 6 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ShahakShama)

---

crates/papyrus_network/src/db_executor/test.rs line 171 at r3 (raw file):

Previously, ShahakShama wrote…

This is the only place we define it, so I see no reason to create a type alias

just made this function hard to read. I think it's worthwhile but won't block