Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(consensus): add test util to more cleanly create validator ids #2125

Conversation

matan-starkware
Copy link
Contributor

@matan-starkware matan-starkware commented Jun 19, 2024

This change is Reviewable

@matan-starkware
Copy link
Contributor Author

matan-starkware commented Jun 19, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @matan-starkware and the rest of your teammates on Graphite Graphite

@matan-starkware matan-starkware marked this pull request as ready for review June 19, 2024 11:05
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.19%. Comparing base (3675c53) to head (dd51d0a).
Report is 98 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2125      +/-   ##
==========================================
- Coverage   67.25%   67.19%   -0.06%     
==========================================
  Files         136      136              
  Lines       17889    17889              
  Branches    17889    17889              
==========================================
- Hits        12031    12021      -10     
- Misses       4532     4542      +10     
  Partials     1326     1326              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matan-starkware matan-starkware force-pushed the 06-19-refactor_consensus_add_test_util_to_more_cleanly_create_validator_ids branch from 5e6df9c to 8af86ca Compare June 20, 2024 11:04
Copy link

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale.
This PR will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions bot added the stale No activity for quite some time. label Jul 25, 2024
@github-actions github-actions bot closed this Aug 1, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
stale No activity for quite some time.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant