Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve specification return types in starknet_simulateTransaction #102

Open
mikiw opened this issue Jun 14, 2023 · 0 comments
Open

Improve specification return types in starknet_simulateTransaction #102

mikiw opened this issue Jun 14, 2023 · 0 comments

Comments

@mikiw
Copy link

mikiw commented Jun 14, 2023

The specification for starknet_simulateTransaction should have a specific trace type like INVOKE_TXN_TRACE, DECLARE_TXN_TRACE, DEPLOY_ACCOUNT_TXN_TRACE instead of using generic TRANSACTION_TRACE that also has L1_HANDLER_TXN_TRACE

https://github.com/starkware-libs/starknet-specs/blob/v0.3.0/api/starknet_trace_api_openrpc.json

It can be achieved by:

  • adding a new type that doesn't contain L1_HANDLER_TXN_TRACE
  • or instead of using "$ref": "#/components/schemas/TRANSACTION_TRACE" explicitly use these types: INVOKE_TXN_TRACE, DECLARE_TXN_TRACE, DEPLOY_ACCOUNT_TXN_TRACE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant