Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

87 autogeneration #88

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

notV4l
Copy link

@notV4l notV4l commented May 4, 2023

rel : #87

  • fix validation error on starknet_write_api

  • fix issues for generating typings for starknet_write_api

  • do not fix issues for generating typings for starknet_trace_api :
    i suspect oneOf / allOf to create infinite loop while generating typings

@notV4l
Copy link
Author

notV4l commented May 4, 2023

for starknet_trace_api :

  • add ADDRESS def to components/schema
 "ADDRESS": {
                "$ref": "./api/starknet_api_openrpc.json#/components/schemas/ADDRESS"
   }
  • yarn gen_trace_api

--> infinite loop :(

@ArielElp ArielElp self-requested a review May 11, 2023 13:20
Copy link
Collaborator

@ArielElp ArielElp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @notV4l)


api/starknet_write_api.json line 145 at r1 (raw file):

                "$ref": "./api/starknet_api_openrpc.json#/components/schemas/FUNCTION_CALL"
            },
            "SIERRA_ENTRY_POINT": {

why do we need all the new references in the write API?

@notV4l
Copy link
Author

notV4l commented May 16, 2023

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @notV4l)

api/starknet_write_api.json line 145 at r1 (raw file):

                "$ref": "./api/starknet_api_openrpc.json#/components/schemas/FUNCTION_CALL"
            },
            "SIERRA_ENTRY_POINT": {

why do we need all the new references in the write API?

i was not able to validate / generate types files without this changes

there is still issues to generate types for the trace_api (infinite loop)

@tabaktoni
Copy link
Contributor

i suspect oneOf / allOf to create infinite loop while generating typings

Infinite loop is from recursive reference: FUNCTION_INVOCATION -> calls -> NESTED_CALL -> FUNCTION_INVOCATION ...
I don't know why it can't handle it, but there is an open issue with generator page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants